Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home Page #10

Open
Aniket762 opened this issue Oct 7, 2020 · 14 comments
Open

Home Page #10

Aniket762 opened this issue Oct 7, 2020 · 14 comments
Assignees

Comments

@Aniket762
Copy link
Member

Make the UI of home page better. Modify the layout for both dark mode and light mode .

Don't forget to include the before and after screenshots.

@ghsayan
Copy link
Contributor

ghsayan commented Oct 7, 2020

Hey I have tried to make some changes to the home page and fixed a bug can I do a PR?

@Aniket762
Copy link
Member Author

Hey I have tried to make some changes to the home page and fixed a bug can I do a PR?

@ghsayan share the screenshot of before and after

@ghsayan
Copy link
Contributor

ghsayan commented Oct 7, 2020

Done. Kindly review them.

@HERITAGEALABI
Copy link

Make the UI of home page better. Modify the layout for both dark mode and light mode .

Don't forget to include the before and after screenshots.

i want to give it a shot

@ankitminglani
Copy link

ankitminglani commented Oct 23, 2020

@Aniket762
Fixed a javascript file load issue and alignment on homepage, please accept my contribution. Thanks
Not sure how to share screenshots here.

@ankitminglani
Copy link

@Aniket762 I see my pull request was closed without merge or any comments. I did not make a large change because it might be too tricky to test or do a code review for.
Please do let me know if you are not looking for any outside contributions for this project

@Aniket762
Copy link
Member Author

Hey @ankitminglani, the changes were very minute and I felt it's not needed so closed the pull request. And yes outside collaborators can contribute. We would love to see the changes you make but first please let me know if you are interested and then I will assign it to you and then you can work on it.

@ankitminglani
Copy link

ankitminglani commented Oct 24, 2020

@Aniket762 I sent a pull request because i was interested in making more contributions to this project. I think a lot of good things can be done. Your readme.md file did not say anything that i have to be assigned an issue to work on it so i just sent a pull request which has worked fine for me with other projects.

In general practice, since this was my first commit to your project i would not want to make ground breaking changes so we both are comfortable working on it and have confidence of taking it to next level.

Do let me know your thoughts.

I did fix a very logical issue in your website. Bootstrap needs jQuery and jquery was loaded after bootstrap, so if you see you will get this error on console log , the site works after a split second once this is resolved by your browser.

The other minor fix was your section titles were touching the edge of the screen so i just aligned them so the site looks little professional.

I would understand if you still dont want to merge my code. The problem statement in the issue itself is sort of open ended.

@abhibhaw
Copy link
Contributor

Sorry for the inconvenience @ankitminglani, your PR was so minor that it got marked as spam by our spammy bot. I have reopened it, kindly go through the revisions before we can merge it.

@smalawad
Copy link

Hey, I have tried to make a new layout for the home page.

following are the screenshots before and after.

Before:
[main-building]

main-building

[branches]
page-2

[course-info]
page-3

[resource]
page-5

[footer]
page-6

After:

[branches]
page-8

[course-info]
page-7

[resource]
page-9

Welcome your valuable feedback changes.

@Aniket762
Copy link
Member Author

Hey, @smalawad thanks for your effort it looks great but we don't want to change the UI of our homepage as of now.

@smalawad
Copy link

smalawad commented Apr 16, 2021

Thanks for your response!

May I know Is the issue still open? how can I contribute to it?

@yas-sisodia
Copy link

@Aniket762 please assign this to me i can solve the issues or modify it

@Aniket762
Copy link
Member Author

@Aniket762 please assign this to me i can solve the issues or modify it

go for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants