Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor template parser #132

Closed
LastLeaf opened this issue Feb 4, 2024 · 0 comments
Closed

Refactor template parser #132

LastLeaf opened this issue Feb 4, 2024 · 0 comments
Assignees
@LastLeaf
Labels
enhancement New feature or request module:template-compiler
Milestone
v0.4

Comments

@LastLeaf
Copy link
Member

LastLeaf commented Feb 4, 2024

Currently, the parser part of the template compiler has several issues.

  • It is ported from some aged code that does not look good from the view of modern rust.
  • It is pest-generated which is not suitable for such complex parser.
  • It lacks some basic features such as line-column so that some features (e.g. Supports getting row offset of inline scripts #35) cannot be implemented.
  • It does not report warnings.
  • We are going to implement a language server, which needs a better parser.

Thus a refactor of the template parser is required. It should be organized like classic rust parser structure such as syn .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LastLeaf LastLeaf

Labels
enhancement New feature or request module:template-compiler
Projects
None yet
Milestone
v0.4
Development

No branches or pull requests
1 participant
@LastLeaf