Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

采用mixins的方式来实现puppet-whatsapp中的方法，并进行合理划分 #40

Closed
su-chang opened this issue Jan 11, 2022 · 1 comment
Closed

采用mixins的方式来实现puppet-whatsapp中的方法，并进行合理划分 #40

su-chang opened this issue Jan 11, 2022 · 1 comment
Assignees
@bung87

Comments

@su-chang
Copy link
Member

目前 wechaty-puppet 中的抽象方法较多，都需要在 puppet-whatsapp 中进行继承实现。会造成该文件中的代码篇幅过长，且不易维护和阅读。

需要将不同分类的方法通过mixins的方式进行归类。
This was referenced Jan 11, 2022
Closed
Closed
@hcfw007
Copy link
Member

hcfw007 commented Jan 12, 2022

确实，否则会导致 puppet-whatsapp，manager 这两个类特别大且重复很高

@hcfw007 hcfw007 mentioned this issue Jan 12, 2022
Closed
3 tasks
@bung87 bung87 mentioned this issue Jan 19, 2022
Merged
@bung87 bung87 self-assigned this Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bung87 bung87

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bung87 @su-chang @hcfw007