Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a beautiful color logger is wanted. #34

Open
wj-Mcat opened this issue Dec 20, 2020 · 3 comments
Open

a beautiful color logger is wanted. #34

wj-Mcat opened this issue Dec 20, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@wj-Mcat
Copy link
Collaborator

wj-Mcat commented Dec 20, 2020

I think there should be a improvement for logger: beautiful log message format can make us happy.

tools:

Pr is welcome ~

@wj-Mcat wj-Mcat added the enhancement New feature or request label Dec 20, 2020
@wj-Mcat
Copy link
Collaborator Author

wj-Mcat commented Mar 7, 2021

In related works, I use loguru loguru a lot. So, I suggest this tool for python-wechaty.

@wj-Mcat wj-Mcat self-assigned this Mar 7, 2021
@huan
Copy link
Member

huan commented Mar 7, 2021

Using an existing logger module/package would be great!

The reason TS/JS Wechaty is using brolog which is written by myself is very simple: I want to use a logger which can compatible with the Node.js & Browser environment together.

If we do not consider the Browser, like Python Wechaty (other Polyglot as well), we can consider using a more mature solution other than writing by ourselves.

@wj-Mcat
Copy link
Collaborator Author

wj-Mcat commented Mar 7, 2021

python-wechaty will not consider browser platform in recent past, so I try to use mature solution for logger.

This is my consideration: beautiful & mature.

If we will use other tool for logger in future, we should only change the implementation of get_logger in wechaty_puppet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants