Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] New event: ROOM_ANNOUNCE #2524

Closed
hcfw007 opened this issue Apr 25, 2023 · 3 comments
Closed

[FEAT] New event: ROOM_ANNOUNCE #2524

hcfw007 opened this issue Apr 25, 2023 · 3 comments

Comments

@hcfw007
Copy link
Member

hcfw007 commented Apr 25, 2023

Room Announcement is a feature that most IMs have, and there is no appropriate event for it in Wecahty so far. A possible work around is to generate a text message when Room Announcement changes, however the best pratice I blieve is to make a new event: Room announce.

The event listener will be somethign like:

export type RoomAnnounceEventListener = (room: RoomInterface, newAnnouncement: string, oldAnnouncement?: string)
  => void | Promise<void>
@hcfw007
Copy link
Member Author

hcfw007 commented Apr 25, 2023

wechaty-puppet: wechaty/puppet#214
wechaty-grpc: wechaty/grpc#193
wechaty-puppet-service: wechaty/puppet-service#230
wechaty: #2527

@huan
Copy link
Member

huan commented Jun 30, 2023

Can we check on related PRs? @hcfw007

Thank you very much!

Copy link

dosubot bot commented Nov 19, 2023

Hi, @hcfw007! I'm Dosu, and I'm here to help the wechaty team manage their backlog. I wanted to let you know that we are marking this issue as stale.

From what I understand, this issue is a request to add a new event called "ROOM_ANNOUNCE" to Wechaty. You, @hcfw007, have submitted several related pull requests, and the maintainer, @huan, has asked for an update on these pull requests. It seems like progress is being made towards adding the new event.

Before we close this issue, we wanted to check with you if it is still relevant to the latest version of the wechaty repository. If it is, please let us know by commenting on this issue. Otherwise, feel free to close the issue yourself, or it will be automatically closed in 7 days.

Thank you for your contribution, and we appreciate your understanding as we manage our backlog. Let us know if you have any further questions or concerns!

Best,
Dosu

@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Nov 19, 2023
@dosubot dosubot bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 26, 2023
@dosubot dosubot bot removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants