Skip to content
This repository has been archived by the owner on Dec 17, 2021. It is now read-only.

debug notice for each menu element when no search results were found #12

Closed
joseluis opened this issue Jun 17, 2014 · 4 comments
Closed

Comments

@joseluis
Copy link
Contributor

This line gets printed before the menu, one time for each link it contains:

Notice: Trying to get property of non-object in /home/.../wp-content/plugins/subtitles/public/class-subtitles.php on line 543

only after searching something that didn't return results.

Tested with multiple themes, including Twenty Fourteen

@philiparthurmoore
Copy link
Member

Not good. What do you mean "only after searching something that didn't return results"? Can you tell me how to reproduce this problem? I'll take care of it immediately. Thanks!

@joseluis
Copy link
Contributor Author

I mean you search something in WP using the search form, and it doesn't find any matches. I'll give you an example URL, I doubt this search term will return any search results:

example.com/?s=dhasdlkjhasd1289uwljkas

See if you can reproduce it in your installation.

@philiparthurmoore
Copy link
Member

Very annoying and easily overlooked bug. :) Thank you so much for spotting this.

@joseluis
Copy link
Contributor Author

You're welcome. Thanks for being awesome.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants