Skip to content
This repository has been archived by the owner on Dec 17, 2021. It is now read-only.

Subtitles repeats and conflicts with my email social share code #40

Closed
MissShugah opened this issue Mar 29, 2015 · 7 comments
Closed

Subtitles repeats and conflicts with my email social share code #40

MissShugah opened this issue Mar 29, 2015 · 7 comments

Comments

@MissShugah
Copy link

Hi Philip,

I'm in love with subtitles but when I use it the social share code in my theme reacts and converts my email share button into text exposing all of the information that goes along with it. The twitter & facebook share buttons are not affected. I'm unsure how to fix this but I did look in my files and dont see "get-titles" or "get_the_titles" & my issue isnt Raw HTML anyway so title commands may not be the problem. Also, in addition to the proper space, the subtitle appears again this time directly above the exploded social share code My developer insists the issue is your plugin so now I have to decide to remove the social share code and hope everything works fine or remove your plugin and lose the effortless subtitle functionality I need.

Here is a photo of what happens when your plugin is activated
https://pbs.twimg.com/media/CA4J8YyVEAAXBhc.png

here is how it should look - plugin not activated
http://www.drcarlhart.com/what-happens-after-nonviolent-drug-offender-are-released/

Please advise on what I should do, thank you very much.

Shug

@philiparthurmoore
Copy link
Member

Hi @MissShugah. Is your social sharing coming from a plugin or is it directly in your theme? Can you show me that code?

@MissShugah
Copy link
Author

The social sharing is a theme shortcode coded into the theme itself to
appear at the bottom of all of my posts. Not sure how to send code, Here's
a copy of whats in there, let me know if there is a better way to receive
it.

  </div>

  <?php if ( $fullwidth != 'on' ) : ?>
    <?php get_sidebar(); ?>
  <?php endif; ?>

</div>

On Sun, Mar 29, 2015 at 8:21 AM, Philip Arthur Moore <
notifications@github.com> wrote:

Hi @MissShugah https://github.com/MissShugah. Is your social sharing
coming from a plugin or is it directly in your theme? Can you show me that
code?


Reply to this email directly or view it on GitHub
#40 (comment)
.

@philiparthurmoore
Copy link
Member

Okay, the reason this is happening is because your shortcode stuff is inside of your Loop (see this). The only way to fix this "easily" would be to disable automatic subtitles and then using the built-in template tags that come with the plugin. Where is the code for your post titles? I don't see that in the above snippet.

@MissShugah
Copy link
Author

I'm thinking of removing the short code completely & searching for a
lightweight share plugin with more functionality. Hopefully the plugin
will function outside of the loop & that will eliminate the issue. I prefer
to keep subtitles automatic. I will let you know if it works after my Yoga
class. :)

Cheers!
On Mar 29, 2015 9:58 AM, "Philip Arthur Moore" notifications@github.com
wrote:

Okay, the reason this is happening is because your shortcode stuff is
inside of your Loop (see this
https://github.com/philiparthurmoore/Subtitles#subtitles-dont-show-up-on-my-site).
The only way to fix this "easily" would be to disable automatic subtitles
and then using the built-in template tags that come with the plugin. Where
is the code for your post titles? I don't see that in the above snippet.


Reply to this email directly or view it on GitHub
#40 (comment)
.

@philiparthurmoore
Copy link
Member

Sounds good. Let me know. Cheers.

@MissShugah
Copy link
Author

Problem solved. Taking your tip about the "loop" I moved the short code further down in the same div and problem went away. :)

@philiparthurmoore
Copy link
Member

Wonderful. Thanks for letting me know!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants