Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Mobile Sidebar Drawer #23

Merged
merged 12 commits into from May 1, 2022
Merged

feat: Mobile Sidebar Drawer #23

merged 12 commits into from May 1, 2022

Conversation

aseer-ws
Copy link
Contributor

@aseer-ws aseer-ws commented Apr 7, 2022

Ticket Link


Related Links


Description


  • Menu Icon appears for mobile devices of width less than 400px
  • Clicking on menu icon open sidebar as drawer
  • Update CI and Jest Coverage Workflow to run for PRs against develop and qa branches

Steps to Reproduce / Test



Checklist

  • PR description included
  • yarn test passes
  • Tests are [changed or added]
  • Relevant documentation is changed or added (and PR referenced)

GIF's


Kapture 2022-04-07 at 16 21 48

@github-actions
Copy link

github-actions bot commented Apr 7, 2022

Jest Coverage Report

Total coverage

Status Category Percentage Covered / Total
🟢 Statements 100% 413/413
🟢 Branches 100% 149/149
🟢 Functions 100% 151/151
🟢 Lines 100% 356/356

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Show new covered files 🌑

Coverage of new files

Status Filename Statements Branches Functions Lines
🟢 utils/constants.ts 100% 100% 100% 100%
🟢 utils/useMobile.ts 100% 100% 100% 100%
🟢 components/Siderbar/index.tsx 100% 100% 100% 100%

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 0262b21

@@ -0,0 +1,20 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of including this in the bundle, can we serve this via the cdn ?
will cloudfront allow for that ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do that later at some point.

app/containers/App/index.tsx Outdated Show resolved Hide resolved
@aseer-ws aseer-ws changed the title feat: Mobile Sidebar Drawer feat: Mobile Sidebar Drawer & fix: Responsive Apr 7, 2022
@aseer-ws aseer-ws changed the title feat: Mobile Sidebar Drawer & fix: Responsive feat: Mobile Sidebar Drawer Apr 11, 2022
@christin-wednesday christin-wednesday merged commit e101d5f into master May 1, 2022
@christin-wednesday christin-wednesday deleted the feat/responsive branch May 1, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants