Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate message parser into separate repo #9

Open
silversquirl opened this issue Jul 29, 2017 · 4 comments
Open

Separate message parser into separate repo #9

silversquirl opened this issue Jul 29, 2017 · 4 comments
Assignees
Labels
feature New feature request

Comments

@silversquirl
Copy link

It'd be nice to expose the functionality of qweechat.weechat.parser to the world and allow others to use it in their own Python programs.

First, I'd recommend reviewing the code and updating it to work with Python 3, which I'm happy to do. I've got a working version exclusively for Python 3 locally, which I can tweak to make it compatible with Python 2.6+.

After that, it's just a matter of separating it out into a new repo (maybe named pyweerelay, pyweechat or python-weechat-relay), creating a PyPI package for it and adding that package as a dependency of qweechat.

@flashcode
Copy link
Member

Hi,

Yes, agreed to make a separate package. I'm currently working on a C library to decode the WeeChat relay protocol (to use in WeeChat itself, see weechat/weechat#369).
So having same package in python would be great, and I can work on that.

For the support of Python versions, I think 2.6 is really not needed (too old). We could maybe keep 2.7+, and of course fully support Python 3.x.

@flashcode flashcode added the feature New feature request label Jul 30, 2017
@flashcode flashcode self-assigned this Jul 30, 2017
@silversquirl
Copy link
Author

silversquirl commented Jul 30, 2017

Great! Want me to clean up my Python 3 port? Not having to keep backwards compatibility with 2.6 will make things easier, since I'm not sure what's in 2.6's __future__ module and what's not.

@flashcode
Copy link
Member

Just found https://github.com/k0rmarun/pyweechat (which is on PyPI), this could maybe already be used in Python relay clients (not tested).

@silversquirl
Copy link
Author

Aha! I hadn't found that. I'll try it out in my current project and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request
Projects
None yet
Development

No branches or pull requests

2 participants