irc: use key when /join-ing in open channel buffer #1260
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a channel buffer is open because it was previously joined, but now has been /part-ed or kicked, the buffer stays open. Running
/joinin it joins to that open channel buffer again. This change makes that/joincall automatically use the known channel key if it's known to weechat, e.g. was used when first joining that channel.Really reusing the known channel key could go even further, e.g. when joining that same channel specifically by name also. This doesn't include that because that would require more complex logic in the JOIN command sending to splice in the correct keys for the correct channels and possibly reorder them to match things up properly.
Happy Hacktoberfest!