Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

color_nick_offline does not affect /me #1492

Closed
NoSuck opened this issue May 2, 2020 · 2 comments
Closed

color_nick_offline does not affect /me #1492

NoSuck opened this issue May 2, 2020 · 2 comments
Labels
bug Unexpected problem or unintended behavior won't fix This will not be implemented/fixed

Comments

@NoSuck
Copy link

NoSuck commented May 2, 2020

Steps to reproduce

  1. /set weechat.look.color_nick_offline on
  2. /me is hungry.
  3. /part

Current behavior

The nick that replaces /me stays the same color.

Expected behavior

The nick's color would change to weechat.color.chat_nick_offline.


@NoSuck NoSuck added the bug Unexpected problem or unintended behavior label May 2, 2020
@flashcode
Copy link
Member

Hi,

This is not really a bug (even if it can be considered as a bug).

The nick in /me messages is displayed in the message itself, not in the prefix. And the option weechat.look.color_nick_offline affects only nicks displayed in prefix.

To fix that it would require breaking changes because WeeChat (core) does not know that irc plugin writes a nick name in the message itself.
So IRC should print /me messages differently to use the message in the prefix, but this would lead to major display changes, and a redesign of /me messages.

For now I may just close this as "won't fix", since it's not a major issue for me.

@NoSuck
Copy link
Author

NoSuck commented May 3, 2020

Thank you for the details. I figured as much. Also, I can't imagine it would be a major issue for anyone, really.

May this issue remain as a search hit for future color_nick_offline searches.

@NoSuck NoSuck closed this as completed May 3, 2020
@flashcode flashcode added the won't fix This will not be implemented/fixed label May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected problem or unintended behavior won't fix This will not be implemented/fixed
Projects
None yet
Development

No branches or pull requests

2 participants