Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSockets broken because header fields treated case-sensitive #888

Closed
mholt opened this issue Jan 10, 2017 · 4 comments
Closed

WebSockets broken because header fields treated case-sensitive #888

mholt opened this issue Jan 10, 2017 · 4 comments
Assignees
Labels
bug Unexpected problem or unintended behavior
Milestone

Comments

@mholt
Copy link

mholt commented Jan 10, 2017

RFC 2616 says that header fields are not case-sensitive. Unfortunately, weechat is treating them case-sensitive. This is causing web servers like Caddy to fail making WebSocket connections to weechat. Rather than break spec/convention in Caddy (and create more code and complexity to maintain), I'd rather like to see weechat treat header fields case-insensitively.

@flashcode flashcode added the bug Unexpected problem or unintended behavior label Jan 10, 2017
@flashcode flashcode self-assigned this Jan 10, 2017
@flashcode flashcode added this to the 1.7 milestone Jan 10, 2017
@flashcode flashcode added the in progress Someone is working on this issue label Jan 10, 2017
@flashcode flashcode removed the in progress Someone is working on this issue label Jan 11, 2017
@mholt
Copy link
Author

mholt commented Jan 11, 2017

Thank you!!

@joelnb
Copy link

joelnb commented Jan 11, 2017

Thanks a lot for your quick work here @flashcode!

@flashcode
Copy link
Member

You're welcome, I hope the fix is working fine (if not please ping me quickly so I can fix before the next release).

@joelnb
Copy link

joelnb commented Jan 13, 2017

@flashcode Had some issues getting it to build but that's all sorted now and I can confirm that the fix is working for me with a vanilla version of Caddy. Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

3 participants