Updated internal variable names to match that of datapackage #860
Conversation
|
@jainamritanshu please work with this branch. reference to #822 |
|
@henrykironde Sure! |
|
@henrykironde @ethanwhite I have been putting some thought about how to tackle the version breaking of version < 2.0.0 for But I guess this would look somewhat redundant and wouldn't look clean. I can not think of something else, I would make a PR with these changes, unless you have something more clean in your mind. |
|
@jainamritanshu How about setting that value in the same chunk of code you're already using for the alternative values. So, e.g., in |
|
Thanks @ethanwhite for the suggestion. This looks so much better than mine approach I will follow this one, and make the changes right away. |
|
@henrykironde I can not see why the commit is failing the checks with the following message - |
|
@jainamritanshu I will go through this. |
|
Tests failing: solved in |
|
Could you provide the results of |
|
@henrykironde this is the result I got when I ran the command |
|
if you debug the script list it shows that the variables are not well initialized for the python scripts |
|
let me know if you understand the problem that exists currently, else I could try explain it differently. |
|
parse_version(VERSION) < parse_version(): |
|
may be |
|
@henrykironde if I am not wrong I guess you are talking about the script variable initialization in I will change the version number asap. |
|
If you checkout master. then run this only displays the script`s shortsnames |
|
@henrykironde when I ran As far as I could understand the arguments for the cli, |
|
@jainamritanshu waiting for updates on the version number |
|
@henrykironde I am getting an error |
|
@jainamritanshu run |
|
|
|
Let me know what you want to do I could help you, |
…ecology#765 The following changes were done for the variable names tags -> keywords nulls -> missingValues name -> title shortname -> name The changes were done in the following files - retriever/lib/compile.py retriever/lib/datapackage.py retriever/lib/engine.py retriever/lib/parse_script_to_json.py retriever/lib/templates.py retriever/lib/tools.py scripts/bioclim.py scripts/biomass_allometry_db.py scripts/breed_bird_survey.py scripts/breed_bird_survey_50stop.py scripts/forest_inventory_analysis.py scripts/gentry_forest_transects.py scripts/npn.py scripts/plant_life_hist_eu.py scripts/prism_climate.py scripts/vertnet.py scripts/wood_density.py scripts/*.json(almost all datapackages) transition missingValues -> missing_values test/test_retriever.py retriever/__main__.py
|
@jainamritanshu I have tried to update this locally and there are many changes, So I advice you to create a new branch and transfer changes to the branch. The main problem comes from the recent changes in the scripts. you can make two commits, that one for the general changes and the other is for the changes in scripts |
|
Sure @henrykironde. Working on it. |
* Updating Internal Variables in scripts * Updating retriever general environment to handle the updated internal variables as per the datapackages/scripts in /retriever/lib/ * Cleaning up Updated internal variable names PR * fixing inconsistency of Cleanup function and missingValues in python scripts
|
This was replaced by #897 which has now been merged. |
Updated internal variable names to match that of datapackage spec #765
The following changes were done for the variable names