Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a simpler way to use custom extractors #7

Closed
marcosh opened this issue Aug 7, 2017 · 1 comment
Closed

Provide a simpler way to use custom extractors #7

marcosh opened this issue Aug 7, 2017 · 1 comment

Comments

@marcosh
Copy link

marcosh commented Aug 7, 2017

As far as I understood the code, the way to provide a custom extractor is to register it among the hydrators.

Could it be an idea to allow the extractor parameter in the ResourceMetadata classes to be an object, and not only a string, to allow users to pass directly an instance of ExtractionInterface?

@weierophinney
Copy link
Owner

Could it be an idea to allow the extractor parameter in the ResourceMetadata classes to be an object, and not only a string, to allow users to pass directly an instance of ExtractionInterface?

No. The idea is that these should be serializable, so that they can be re-used between requests. If we have objects involved, this becomes less manageable and predictable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants