Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

建议移除标签名选择器,以避污染组件样式 #22

Closed
gaollg opened this issue Jan 8, 2019 · 3 comments
Closed

建议移除标签名选择器,以避污染组件样式 #22

gaollg opened this issue Jan 8, 2019 · 3 comments
Labels
优化 用户提出的项目细节优化 已经完成 现在的版本已经解决(优化)了这个问题

Comments

@gaollg
Copy link

gaollg commented Jan 8, 2019

image
如截图所示,colorUI 的全局样式,已经影响到自定义组件样式,尤其还有后缀有 !important 的属性。详见微信小程序自定义组件 - 使组件接受全局样式

建议处理方式:

  1. 借鉴 Vant 的做法,例将 button 前缀字符为 van-button。
  2. 弃用标签名选择器,改用 class 表示,缺点是 Html 标签变长了一些。
@gaollg
Copy link
Author

gaollg commented Jan 8, 2019

image
再补充一个,class*="" 也会破坏组件的内部结构。

@wen-gang
Copy link
Collaborator

wen-gang commented Jan 8, 2019

colorui 不考虑兼容其他组件库,作为样式类的库,也没有考虑做出小程序自定义组件,

@wen-gang wen-gang closed this as completed Jan 8, 2019
@wen-gang
Copy link
Collaborator

wen-gang commented Jan 8, 2019

关于是否抛弃标签名选择器,有在考虑,近期不会变动。感谢支持。

@wen-gang wen-gang reopened this Jan 8, 2019
@wen-gang wen-gang closed this as completed Jan 8, 2019
@wen-gang wen-gang added 优化 用户提出的项目细节优化 已经完成 现在的版本已经解决(优化)了这个问题 labels Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
优化 用户提出的项目细节优化 已经完成 现在的版本已经解决(优化)了这个问题
Projects
None yet
Development

No branches or pull requests

2 participants