LessSpecificImplementedReturnType false-positive

[fluffycondor]

LessSpecificImplementedReturnType - src/Repository/SomethingRepository.php:9:12 - The inherited return type 'list<App\Entity\Something>' for Doctrine\ORM\EntityRepository::findAll is more specific than the implemented return type for Doctrine\ORM\EntityRepository::findall 'array<array-key, App\Entity\Something>'

Code in my SomethingRepository:

/**
 * @method Something[]    findAll() (this PHPDoc was auto-generated by Symfony)
 * @extends ServiceEntityRepository<Something>
 */
class SomethingRepository extends ServiceEntityRepository
{
 */

This is a snippet from Doctrine\ORM\EntityRepository

/**
 * Finds all entities in the repository.
 *
 * @return array The entities.
 */
public function findAll()
{
    return $this->findBy([]);
}

Just an array.

This is from Doctrine\Persistence\ObjectRepository that implemented by Doctrine\ORM\EntityRepository:

/**
 * Contract for a Doctrine persistence layer ObjectRepository class to implement.
 *
 * @template T
 */
interface ObjectRepository
{
.....

    /**
     * Finds all objects in the repository.
     *
     * @return array<int, object> The objects.
     *
     * @psalm-return T[]
     */
    public function findAll();
....
}

So it returns just T[], Something[] in my case.

Looks like there is a problem in the plugin's stub files.

[weirdan]

As far as I can see (based on comments in this doctrine/persistence PR), there's indeed a problem with ObjectRepository stub where findAll() should return T[], but there's no issue with descendant return types. ORM repository actually returns list<T>.

[fluffycondor]

Is there any info when there will be a new release with all of the bugfixes? :)

[weirdan]

I want to fix remaining deprecation errors first, so it would be some time next week.

[nsetyo]

@weirdan I'm still getting this error

Based what I see ServiceEntityRepository extends EntityRepository and in EntityRepository findAll still return list<T>
How should I fix this?