Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flags encoding inconsistency between REAMDE and code #90

Open
daejunpark opened this issue May 18, 2022 · 1 comment · May be fixed by #86
Open

Flags encoding inconsistency between REAMDE and code #90

daejunpark opened this issue May 18, 2022 · 1 comment · May be fixed by #86

Comments

@daejunpark
Copy link

In README, tup is at MSB, and ext is the next:

  0   1   2   3   4   5   6   7
┌───┬───┬───────────────┬────────┐
│tup│ext│   reserved    │calltype│
└───┴───┴───────────────┴────────┘

but in the code, ext is at MSB, and tup is the next:

weiroll/contracts/VM.sol

Lines 12 to 13 in ebc6d70

uint256 constant FLAG_EXTENDED_COMMAND = 0x80;
uint256 constant FLAG_TUPLE_RETURN = 0x40;

Users who encode flags following the README would experience unexpected behaviors.
@georgercarder
Copy link
Contributor

I caught this too and fixed it in this PR #86

@decanus decanus linked a pull request May 19, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix critical 17 and flag bug georgercarder/weiroll
2 participants
@daejunpark @georgercarder