Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you please clarify how darklaf relates to the current Darcula? #19

Closed
vlsi opened this issue Feb 14, 2020 · 2 comments
Closed

Can you please clarify how darklaf relates to the current Darcula? #19

vlsi opened this issue Feb 14, 2020 · 2 comments

Comments

@vlsi
Copy link
Contributor

vlsi commented Feb 14, 2020

Thanks for the LaF.

AFAIK, the up to date Darcula is located in IDEA's repository: https://github.com/JetBrains/intellij-community/tree/1bc324ce785de1917f3ad0e0f99ceb4bf895105a/platform/platform-impl/src/com/intellij/ide/ui/laf/darcula

Can you please clarify if darklaf builds upon that version or not?

@weisJ
Copy link
Owner

weisJ commented Feb 14, 2020

Darklaf originally started as an extension of Darcula implementing the newer design language of the Jetbrains products. Some things are taken from the IntelliJ repository and rewritten to not rely on IntelliJ specific APIs. In a way this project is part an extension of the old Darcula project part port/decoupling of the Darcula LaF as it sits in the IntelliJ repository and part custom written extension of the aforementioned (with the latter being the bulk portion).

I hope this answers your question :).

@vlsi
Copy link
Contributor Author

vlsi commented Feb 14, 2020

Oh, I see.
Konstantin said that their vision on Darcula is it might make sense to decouple darcula-inside-intellij from intellij platform, then it could be reused for other places.

I just thought you made that happen.

Now I see you are doing a mix :)

@vlsi vlsi closed this as completed Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants