Folder structure to prevent export bugs #9
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that
usize
is not exported innoeval.ts
, even thoughusize
doesn't use eval. I guess it's a bug, because innoeval.ts
you had to export every serdes other thanstruct
andnumber
manually, and it's easy to forget to export something.What about using such folder structure so it's harder to miss something:
shared_serdes
contains serdeses which can be used both in eval and noevalserdes
contains serdeses which use evalnoeval_serdes
contains versions of serdeses fromserdes
, but without eval usageThere are 4 index files for every combination Node.js/not Node.js and eval/noeval.
shared.ts
contains common exports