Fix home gesture collision #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The home-gesture on iOS devices without a physical home button can collide with the DragGesture that is attached to the bottom sheet. The gesture allows to hide the presented bottom sheet by dragging the top bar down to the edge of the screen. However, when swiping up from the bottom to send the app to the background, the gesture still receives changes. When the bottom sheet is hidden, this can lead to a miscalculation of the sheet position. See the attached video to the PR. The fix is to ignore the swipe-up gesture when the bottom sheet is hidden.
weitieda
reviewed
Apr 28, 2022
|
👍🏼 Thanks for fixing this. I've left few comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The home-gesture on iOS devices without a physical home button can collide with the
DragGesture that is attached to the bottom sheet. The gesture allows to hide the
presented bottom sheet by dragging the top bar down to the edge of the screen.
However, when swiping up from the bottom to send the app to the background, the
gesture still receives changes. When the bottom sheet is hidden, this can lead to a
miscalculation of the sheet position. See the attached video:
The fix is to ignore the swipe-up gesture when the bottom sheet is hidden.