-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flicker when using bottom sheet starting with isPresented == false #21
Comments
same here. did you do something about it? edit: actually i did not have the |
Yes, I can see how that would fix it but I don't want to pollute my topmost view with this logic. So my hack to fix it was keep bottom views alpha at 0 and in onAppear I switch it on after a short delay. I think the root problem is unless at the top level view, the geometry reader evaluates to zero the first time body gets called. A quick fix would be to have the bottom sheet return nothing when that is the case. |
Maybe I'll do a pull request at some point |
@nimrodbens Should be fixed by #22 and shout out to @joncottrell for working on this, thanks. |
Closing this issue for now and feel free to open new one if necessary |
The way to reproduce is to put a simple Rectangle in the BottomSheet and start with isPresented = false. While the GeometryReader is loading, the offset is incorrect and creates a flicker.
The text was updated successfully, but these errors were encountered: