Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add onDismiss to control user interfaces #24

Merged
merged 3 commits into from
Nov 13, 2022
Merged

add onDismiss to control user interfaces #24

merged 3 commits into from
Nov 13, 2022

Conversation

jkimdev
Copy link
Contributor

@jkimdev jkimdev commented Nov 4, 2022

I think that some actions are needed when bottom sheet is closed.
it is little tricky to dismiss the keyboard to TextField on iOS 14, so I added escaping function. Please consider it for the next version! Thank you so much for your library.

Copy link
Owner

@weitieda weitieda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. It's pretty cool to add this. 👍

The closure seems bit off for me. Let's make it optional, default to nil to avoid api change.

Sources/BottomSheet/BottomSheet.swift Outdated Show resolved Hide resolved
@jkimdev
Copy link
Contributor Author

jkimdev commented Nov 6, 2022

I will fix it tomorrow morning! Thank you!

@jkimdev jkimdev requested a review from weitieda November 8, 2022 23:57
Copy link
Owner

@weitieda weitieda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

One last nit: mind removing the unwrap?

Sources/BottomSheet/BottomSheet.swift Outdated Show resolved Hide resolved
Copy link
Owner

@weitieda weitieda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@weitieda weitieda merged commit 224d7c0 into weitieda:master Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants