Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TorchsearchSorted module #3

Closed
DingYikang opened this issue Sep 13, 2021 · 3 comments
Closed

Remove TorchsearchSorted module #3

DingYikang opened this issue Sep 13, 2021 · 3 comments

Comments

@DingYikang
Copy link

Hi,
Thanks for your great work! I think you can replace the 'torchsearchsorted' module with 'torch.searchsorted()'. When I use NVIDIA GeForce RTX 2080 (same with you) to intall 'torchsearchsorted', I met some 'unsupported gpu architecture'. Maybe you can share how to install 'torchsearchsorted' on 2080 gpu with me.
This is a nice work. Thanks!

@weiyithu
Copy link
Owner

We use https://github.com/aliutkus/torchsearchsorted to install torchsearchsorted. torchsearchsorted only appears in run_nerf_helpers.py, which we directly copy from https://github.com/yenchenlin/nerf-pytorch. Indeed, we do not use this sample_pdf function in our method. Thus, if you have trouble installing the package, you can directly remove this function in run_nerf_helpers.py.

@DingYikang
Copy link
Author

I use https://github.com/aliutkus/torchsearchsorted to install it, too. And I have solved this problem by repalcing this function with 'torch.searchsorted()'. I found you have not mentioned this dependcy in Readme.txt. For easy-using, maybe you can fix this part.
Thanks for your reply.

@weiyithu
Copy link
Owner

OK, I will delete sample_pdf function. Thanks for your suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants