New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support LibreJS #1040

Open
alexgleason opened this Issue May 14, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@alexgleason
Copy link

alexgleason commented May 14, 2017

LibreJS blocks all nonfree javascript, but it cannot tell whether javascript is free unless there is a license.

LibreJS blocks these two scripts in Wekan:

  • This script is detected as inline, nonfree, defining functions or methods, and the rest of the page as loading external scripts
__meteor_runtime_config__ = JSON.parse(decodeURIComponent("%7B%22meteorRelease%22%3A%22METEOR%401.4.4.1%22%2C%22meteorEnv%22%3A%7B%22NODE_ENV%22%3A%22production%22%2C%22TEST_METADATA%22%3A%22%7B%7D%22%7D%2C%22PUBLIC_SETTINGS%22%3A%7B%7D%2C%22ROOT_URL%22%3A%22https%3A%2F%2Fboard.uptwinkles.co%22%2C%22ROOT_URL_PATH_PREFIX%22%3A%22%22%2C%22appId%22%3A%22dvyihgykyzec6y1dpg%22%2C%22accountsConfigCalled%22%3Atrue%2C%22autoupdateVersion%22%3A%229b97c8bb6da550226ee206b9c7735877d0cadd3b%22%2C%22autoupdateVersionRefreshable%22%3A%2251df0013f3ee164898be2499f2ffe40a222b0688%22%2C%22autoupdateVersionCordova%22%3A%22none%22%7D"));

The first can be fixed by surrounding it with a magnet link license code, like so:

<script>
// @license magnet:?xt=urn:btih:d3d9a9a6595521f9666a5e94cc830dab83b65699&dn=expat.txt MIT
... [script is here] ...
// @license-end
</script>

and the second one can be fixed by adding a comment to the beginning of the script file, like this:

/**
 *
 * @source: https://github.com/wekan/wekan/tree/MAIN_JS_FILE_HERE.js
 *
 * @licstart  The following is the entire license notice for the 
 *  JavaScript code in this page.
 *
 * The MIT License (MIT)
 *
 * Copyright (c) 2014-2016 The Wekan Team
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in all
 * copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 *
 * @licend  The above is the entire license notice
 * for the JavaScript code in this page.
 *
 */
@xet7

This comment has been minimized.

Copy link
Member

xet7 commented May 19, 2017

I did not yet figure out how to add it to meteor build process that produces randomly named javascript file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment