Debug opt, test coverage, and a better embed conditional #7

isaacs · 2019-01-03T21:57:02Z

Adds the debug option, no output otherwise.
Tests! And 100% coverage, because why not? Didn't do anything for gatsby-browser.js, since I'm not sure how best to test that.
I found that it was doing the embed when I had a link in a paragraph, like this https://twitter.com/... is a tweet, which broke things, so I updated the AST conditional checking.

Otherwise it does really wierd things to inline links to tweets, which looks pretty bad.

With 100% coverage, just for bonus points. TODO: Still need tests for the gatsby-browser.js file, not sure the best way to go about that. Some kind of browser shim thing?

I just realized that when/if I change my twitter handle, it'll break tests for this module. Oops! Fix that by trimming the string to just the beginning part.

jmolivas · 2019-01-09T03:07:02Z

Thanks for the PR @isaacs

Tagging a new release in a few.

isaacs added 7 commits January 3, 2019 10:54

Move async/await out of visitor function

f923069

Fix octahedroid#5

Add debug: true option, turn off output otherwise

78109cd

Only embed when twitter link on a line by itself

0569af0

Otherwise it does really wierd things to inline links to tweets, which looks pretty bad.

Add tests

78297b8

With 100% coverage, just for bonus points. TODO: Still need tests for the gatsby-browser.js file, not sure the best way to go about that. Some kind of browser shim thing?

Add package-lock.json file

aff0c3b

Ignore coverage folder

56ed223

Make blockquote string not as network-dependent

8bd907a

I just realized that when/if I change my twitter handle, it'll break tests for this module. Oops! Fix that by trimming the string to just the beginning part.

jmolivas merged commit adf0d8b into octahedroid:master Jan 9, 2019

jmolivas mentioned this pull request Jan 9, 2019

Move async/await out of visitor function #6

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Debug opt, test coverage, and a better embed conditional #7

Debug opt, test coverage, and a better embed conditional #7

isaacs commented Jan 3, 2019

jmolivas commented Jan 9, 2019

Debug opt, test coverage, and a better embed conditional #7

Debug opt, test coverage, and a better embed conditional #7

Conversation

isaacs commented Jan 3, 2019

jmolivas commented Jan 9, 2019