Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in TPCH-Q1 with weld v0.3.0 #4

Open
harumichi opened this issue Jul 24, 2019 · 0 comments
Open

Error in TPCH-Q1 with weld v0.3.0 #4

harumichi opened this issue Jul 24, 2019 · 0 comments

Comments

@harumichi
Copy link

Error in TPCH-Q1 can be seen in #3, but it is too old, so I create new issue.

I have applied below patch to make it work with v0.3.0

diff --git a/benchmarks/tpch_q1/tpch_q1.cpp b/benchmarks/tpch_q1/tpch_q1.cpp
index 29842d0..844662e 100644
--- a/benchmarks/tpch_q1/tpch_q1.cpp
+++ b/benchmarks/tpch_q1/tpch_q1.cpp
@@ -154,7 +154,10 @@ int32_t run_query_weld(struct gen_data *d) {

    // Run the module and get the result.
     conf = weld_conf_new();
-    weld_value_t result = weld_module_run(m, conf, weld_args, e);
+
+    weld_context_t context = weld_context_new(conf);
+
+    weld_value_t result = weld_module_run(m, context, weld_args, e);
     if (weld_error_code(e)) {
         const char *err = weld_error_message(e);
         printf("Error message: %s\n", err);

We see below error when we have run executable made with patched sources,

./bench
-p 1.0 -n 100000000
Single-threaded C++: 1.203855 (result=-2130815916)


Weld compile time: 0.073685
Error message: Module verification failed: Intrinsic has incorrect argument type!
void (i8*, i8*, i64, i32, i1)* @llvm.memcpy.p0i8.p0i8.i64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant