Use Jest as test runner for end to end test instead of Mocha #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atodorov
requested changes
Jun 23, 2017
There was a problem hiding this comment.
Looks good except the comment I made but the e2e tests fail with the following error:
> jest --runInBand
PASS test/test_viewRecipe.js (54.575s)
PASS test/test_editRecipe.js (48.773s)
(node:33) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: expect(received).toBe(expected)
Expected value to be (using ===):
"UI automation recipe"
Received:
"Automatically Tuned Linear Algebra Software"
FAIL test/test_recipes.js (59.058s)
● Recipes Page › Recipe List › Single Word Recipe Name Scenario › Recipe Content Check #acceptance › should have correct recipe description on list after new recipe added @recipes-page
Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
at pTimeout (node_modules/jest-jasmine2/build/queueRunner.js:53:21)
at Timeout.callback [as _onTimeout] (node_modules/jsdom/lib/jsdom/browser/Window.js:523:19)
at ontimeout (timers.js:365:14)
at tryOnTimeout (timers.js:237:5)
at Timer.listOnTimeout (timers.js:207:5)
PASS test/test_createRecipe.js
PASS test/test_importSanity.js
Test Suites: 1 failed, 4 passed, 5 total
Tests: 1 failed, 64 passed, 65 total
Snapshots: 0 total
Time: 168.51s
Ran all test suites.
Please fix the comment and test execution and we can safely merge.
| @@ -47,6 +47,7 @@ | |||
| "eslint": "^3.17.1", | |||
| "eslint-config-airbnb": "^9.0.1", | |||
| "eslint-plugin-import": "^1.12.0", | |||
| "eslint-plugin-jest": "^20.0.3", | |||
There was a problem hiding this comment.
Shouldn't we remove the mocha plugin then ?
|
Issue resolved, mocha and chai related package deleted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.