Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

html/css updates for independent scrolling #123

Merged
merged 3 commits into from
Aug 1, 2017
Merged

html/css updates for independent scrolling #123

merged 3 commits into from
Aug 1, 2017

Conversation

jgiardino
Copy link
Contributor

@jgiardino jgiardino commented Jul 25, 2017 •
edited

These updates include the following:

  • ability to separately scroll the the list of inputs and the list of recipe components
    • additionally, this required changing the position of the tooltips that display in the inputs panel, since contents in one panel cannot overlap another panel
  • consistent html/css for headers that display in the Recipe page, Recipe Edit page, and the component details
  • component details display as a panel with a panel title on both the Recipe page and Recipe Edit page
  • updated styles for the form that displays when viewing component details

@jgiardino jgiardino requested a review from henrywang July 25, 2017 19:34
@coveralls
Copy link

coveralls commented Jul 25, 2017 •
edited

Coverage Status

Coverage decreased (-0.004%) to 7.861% when pulling 4f3bc3d on jgiardino:CSS into 3495ca5 on weldr:master.

@jgiardino
Copy link
Contributor Author

(5) [UI dev] Edit Recipe page scrolling

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 7.861% when pulling e191573 on jgiardino:CSS into 3495ca5 on weldr:master.

@henrywang
Copy link
Member

The badge indicating number of dependencies cannot update the number when component is added and removed.

@jgiardino
removing badge from tabs
acd58b5 
Given that the tabs component does not
support dynamic content, I'm removing the
badge that indicates number on list items
in the tab, until a tabs component is created
within this project (instead of imported).
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 7.881% when pulling acd58b5 on jgiardino:CSS into 3495ca5 on weldr:master.

henrywang
henrywang approved these changes Aug 1, 2017
View reviewed changes
Copy link
Member

@henrywang henrywang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
It passed regression tests.

@jgiardino jgiardino merged commit f6d5b70 into osbuild:master Aug 1, 2017
@jgiardino jgiardino deleted the CSS branch June 27, 2018 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrywang henrywang henrywang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jgiardino @coveralls @henrywang