Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eta-reduce type-synonyms #66

Closed
phadej opened this issue Jan 14, 2019 · 2 comments
Closed

Eta-reduce type-synonyms #66

phadej opened this issue Jan 14, 2019 · 2 comments
Labels
design design questions

Comments

@phadej
Copy link
Contributor

phadej commented Jan 14, 2019

Now (soon)

type Lens s t a b = Optic A_Lens '[] s t a b

Or should we have just

type Lens = Optic A_Lens '[]
@kosmikus
Copy link
Member

Isn't the problem that this breaks down for e.g. Lens'? We have Optic', but that's also a type synonym and therefore cannot be partially applied.

So for overall symmetry, I think it might be best to keep everything eta-expanded in this case.

@phadej
Copy link
Contributor Author

phadej commented Jan 14, 2019

@kosmikus fair point.

@phadej phadej closed this as completed Jan 14, 2019
@phadej phadej added the design design questions label Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design design questions
Projects
None yet
Development

No branches or pull requests

2 participants