Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return catalogue error responses on non-works pages #2881

Merged
merged 12 commits into from Oct 23, 2018

Conversation

@alexwlchan
Copy link
Member

commented Oct 22, 2018

Resolves #2874. This ensures that a request for any page – not just one of our defined paths – will return a full JSON body, and not an empty response.

Plus a few bits of refactoring, but nothing major.

@alexwlchan alexwlchan requested a review from wellcometrust/weco-devs Oct 22, 2018
@alexwlchan alexwlchan force-pushed the api-404 branch from 6dd387a to c7f6f1f Oct 22, 2018
@kenoir
kenoir approved these changes Oct 22, 2018
Copy link
Collaborator

left a comment

Nice bit of clean up 👍

@alexwlchan alexwlchan force-pushed the api-404 branch from 2deae06 to 56637d8 Oct 23, 2018
@alexwlchan alexwlchan merged commit 871b3f4 into master Oct 23, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alexwlchan alexwlchan deleted the api-404 branch Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.