RangeError: Maximum call stack size exceeded #168

odeal4ik · 2020-12-23T12:04:14Z

Hello, i implemented your thing to my project
And it goes fine.

"@babel/preset-react": "^7.9.4",
"react": "^16.13.1",
"react-dom": "^16.13.1",
"react-redux": "^7.2.0",
"@welldone-software/why-did-you-render": "^6.0.3",

When i use it with [hrm], after some changes in files with code, it reloads fine.
But, if i press f5, for example, my app crashes with error RangeError: Maximum call stack size exceeded...

RangeError: Maximum call stack size exceeded at Object.apply (C:\Develop\auchan-ecom-food-front\.yarn\$$virtual\@welldone-software-why-did-you-render-virtual-0f42de02d0\0\cache\@welldone-software-why-did-you-render-npm-6.0.3-f9d43ade3b-2.zip\node_modules\@welldone-software\why-did-you-render\src\whyDidYouRender.js:236:22) at Object.apply (C:\Develop\auchan-ecom-food-front\.yarn\$$virtual\@welldone-software-why-did-you-render-virtual-0f42de02d0\0\cache\@welldone-software-why-did-you-render-npm-6.0.3-f9d43ade3b-2.zip\node_modules\@welldone-software\why-did-you-render\src\whyDidYouRender.js:257:40) at Object.apply (C:\Develop\auchan-ecom-food-front\.yarn\$$virtual\@welldone-software-why-did-you-render-virtual-0f42de02d0\0\cache\@welldone-software-why-did-you-render-npm-6.0.3-f9d43ade3b-2.zip\node_modules\@welldone-software\why-did-you-render\src\whyDidYouRender.js:257:40) at Object.apply (C:\Develop\auchan-ecom-food-front\.yarn\$$virtual\@welldone-software-why-did-you-render-virtual-0f42de02d0\0\cache\@welldone-software-why-did-you-render-npm-6.0.3-f9d43ade3b-2.zip\node_modules\@welldone-software\why-did-you-render\src\whyDidYouRender.js:257:40) at Object.apply (C:\Develop\auchan-ecom-food-front\.yarn\$$virtual\@welldone-software-why-did-you-render-virtual-0f42de02d0\0\cache\@welldone-software-why-did-you-render-npm-6.0.3-f9d43ade3b-2.zip\node_modules\@welldone-software\why-did-you-render\src\whyDidYouRender.js:257:40) at Object.apply (C:\Develop\auchan-ecom-food-front\.yarn\$$virtual\@welldone-software-why-did-you-render-virtual-0f42de02d0\0\cache\@welldone-software-why-did-you-render-npm-6.0.3-f9d43ade3b-2.zip\node_modules\@welldone-software\why-did-you-render\src\whyDidYouRender.js:257:40) at Object.apply (C:\Develop\auchan-ecom-food-front\.yarn\$$virtual\@welldone-software-why-did-you-render-virtual-0f42de02d0\0\cache\@welldone-software-why-did-you-render-npm-6.0.3-f9d43ade3b-2.zip\node_modules\@welldone-software\why-did-you-render\src\whyDidYouRender.js:257:40) at Object.apply (C:\Develop\auchan-ecom-food-front\.yarn\$$virtual\@welldone-software-why-did-you-render-virtual-0f42de02d0\0\cache\@welldone-software-why-did-you-render-npm-6.0.3-f9d43ade3b-2.zip\node_modules\@welldone-software\why-did-you-render\src\whyDidYouRender.js:257:40) at Object.apply (C:\Develop\auchan-ecom-food-front\.yarn\$$virtual\@welldone-software-why-did-you-render-virtual-0f42de02d0\0\cache\@welldone-software-why-did-you-render-npm-6.0.3-f9d43ade3b-2.zip\node_modules\@welldone-software\why-did-you-render\src\whyDidYouRender.js:257:40) at Object.apply (C:\Develop\auchan-ecom-food-front\.yarn\$$virtual\@welldone-software-why-did-you-render-virtual-0f42de02d0\0\cache\@welldone-software-why-did-you-render-npm-6.0.3-f9d43ade3b-2.zip\node_modules\@welldone-software\why-did-you-render\src\whyDidYouRender.js:257:40) at Object.apply (C:\Develop\auchan-ecom-food-front\.yarn\$$virtual\@welldone-software-why-did-you-render-virtual-0f42de02d0\0\cache\@welldone-software-why-did-you-render-npm-6.0.3-f9d43ade3b-2.zip\node_modules\@welldone-software\why-did-you-render\src\whyDidYouRender.js:257:40) at Object.apply (C:\Develop\auchan-ecom-food-front\.yarn\$$virtual\@welldone-software-why-did-you-render-virtual-0f42de02d0\0\cache\@welldone-software-why-did-you-render-npm-6.0.3-f9d43ade3b-2.zip\node_modules\@welldone-software\why-did-you-render\src\whyDidYouRender.js:257:40) at Object.apply (C:\Develop\auchan-ecom-food-front\.yarn\$$virtual\@welldone-software-why-did-you-render-virtual-0f42de02d0\0\cache\@welldone-software-why-did-you-render-npm-6.0.3-f9d43ade3b-2.zip\node_modules\@welldone-software\why-did-you-render\src\whyDidYouRender.js:257:40) at Object.apply (C:\Develop\auchan-ecom-food-front\.yarn\$$virtual\@welldone-software-why-did-you-render-virtual-0f42de02d0\0\cache\@welldone-software-why-did-you-render-npm-6.0.3-f9d43ade3b-2.zip\node_modules\@welldone-software\why-did-you-render\src\whyDidYouRender.js:257:40) at Object.apply (C:\Develop\auchan-ecom-food-front\.yarn\$$virtual\@welldone-software-why-did-you-render-virtual-0f42de02d0\0\cache\@welldone-software-why-did-you-render-npm-6.0.3-f9d43ade3b-2.zip\node_modules\@welldone-software\why-did-you-render\src\whyDidYouRender.js:257:40) at Object.React.createElement (C:\Develop\auchan-ecom-food-front\.yarn\$$virtual\@welldone-software-why-did-you-render-virtual-0f42de02d0\0\cache\@welldone-software-why-did-you-render-npm-6.0.3-f9d43ade3b-2.zip\node_modules\@welldone-software\why-did-you-render\src\whyDidYouRender.js:257:40)

here is config and import

i can't understand what to do.
if needed some more info, pls report

The text was updated successfully, but these errors were encountered:

odeal4ik · 2020-12-23T13:04:20Z

Upd. tried to watch one component by option include , and got the same thing.

vzaidman · 2020-12-23T13:17:54Z

thanks ill look at it soon

vzaidman · 2020-12-23T17:38:41Z

@odeal4ik
can you please check what is on line 257 of:
node_modules\@welldone-software\why-did-you-render\src\whyDidYouRender.js
and also line 236

also, there is actually no "src" in node_modules\@welldone-software\why-did-you-render what kind of system do you use that it exists there?

vzaidman · 2020-12-23T17:40:10Z

also, what webpack / create-react-app do you use?

odeal4ik · 2020-12-23T20:58:14Z

@odeal4ik
can you please check what is on line 257 of:
node_modules\@welldone-software\why-did-you-render\src\whyDidYouRender.js
and also line 236

also, there is actually no "src" in node_modules\@welldone-software\why-did-you-render what kind of system do you use that it exists there?

I thought this is it ?!...

win10

odeal4ik · 2020-12-23T20:59:26Z

also, what webpack / create-react-app do you use?

not create app
i can give full list of dependencies if it needed

vzaidman · 2020-12-24T06:51:18Z

how did you install the package?

npm install @welldone-software/why-did-you-render

?
because it has no src. only dist

vzaidman · 2020-12-24T06:57:02Z

also-
can you try adding this at the bottom of the wdyr file?

if (process.env.NODE_ENV === 'development') {
  if (module.hot) {
    module.hot.decline();
  }
}

odeal4ik · 2020-12-24T07:50:39Z

how did you install the package?

by yarn add @welldone-software/why-did-you-render

vzaidman · 2020-12-24T08:01:16Z

try clearing cache and reinstall

yarn cache clean

and

yarn install --force

odeal4ik · 2020-12-24T08:27:38Z

i use
rm -rf .yarn/cache
rm -rf yarn.lock

then yarn install my dependencies, but now i have some problem with start my app, it lil crashes.

if (process.env.NODE_ENV === 'development') { if (module.hot) { module.hot.decline(); } }
you just want to "disable" hot in this mode?

vzaidman · 2020-12-24T08:34:27Z

only on the wdyr file

odeal4ik · 2020-12-24T08:52:11Z

for proof it module, and module.hot in wdyr.ts file, and problem is the same, it still crashes after page reload

vzaidman · 2020-12-24T09:20:23Z

are you using Yarn 2?

odeal4ik · 2020-12-24T09:24:03Z

oh yeah, i forgot to notice that

vzaidman · 2020-12-24T09:29:21Z

Maybe try yarn 1? I dont know how it works

odeal4ik · 2020-12-24T09:41:26Z

oh, too many things were made for using yarn 2...i'll try on this project somehow to change on v1, but it seems to me, that i'll see more bugs with this.

odeal4ik · 2020-12-24T10:47:49Z

i tried on cra with yarn 1 and hot reload, and all goes fine (

vzaidman · 2020-12-24T11:00:43Z

i think it has to do with yarn2 cache. it looks bugged to me because there's no

@welldone-software\why-did-you-render\src

only

@welldone-software\why-did-you-render\dist

I'm glad it works!

odeal4ik · 2020-12-24T13:49:21Z

Ok, i think it's a yarn problem, but, i patch my yarn config, and duplicate dependencies in node_modules, and they are there, it 100%.

But error still exist

And why it links to sourse libs files? Not to modules?

davidgilbertson · 2020-12-30T02:38:18Z

I'm getting the same issue. I don't use yarn. Nothing happens on a few pages, then one page does this:

 RangeError: Maximum call stack size exceeded
[0]     at getWDYRType (C:\Users\david\web\keplar\node_modules\@welldone-software\why-did-you-render\dist\whyDidYouRender.js:1418:25)
[0]     at Object.React.createElement (C:\Users\david\web\keplar\node_modules\@welldone-software\why-did-you-render\dist\whyDidYouRender.js:1444:22)
[0]     at Object.React.createElement (C:\Users\david\web\keplar\node_modules\@welldone-software\why-did-you-render\dist\whyDidYouRender.js:1471:42)
[0]     at Object.React.createElement (C:\Users\david\web\keplar\node_modules\@welldone-software\why-did-you-render\dist\whyDidYouRender.js:1471:42)
[0]     at Object.React.createElement (C:\Users\david\web\keplar\node_modules\@welldone-software\why-did-you-render\dist\whyDidYouRender.js:1471:42)
[0]     at Object.React.createElement (C:\Users\david\web\keplar\node_modules\@welldone-software\why-did-you-render\dist\whyDidYouRender.js:1471:42)

I'm using Next.js which will be doing some server-rendering.

Setup is a copy/paste from the readme (I'm using TypeScript):

/// <reference types="@welldone-software/why-did-you-render" />
import React from 'react';

if (process.env.NODE_ENV === 'development') {
  const whyDidYouRender = require('@welldone-software/why-did-you-render');
  whyDidYouRender(React, {
    trackAllPureComponents: true,
  });
  // Tried with and without this:
  if (module.hot) {
    module.hot.decline();
  }
}

Node: 14.14.0
npm: 6.14.0

Some other versions, not sure what might be relevant

    "@welldone-software/why-did-you-render": "^6.0.4",
    "next": "^9.5.5",
    "react": "^16.13.1",
    "react-dom": "^16.13.1",
    "typescript": "^4.1.3",

vzaidman · 2020-12-30T07:26:18Z

@davidgilbertson what version of Next.js / React?

vzaidman · 2020-12-30T07:56:24Z

ok! I've managed to reproduce the bug in next.js and fixed it in version @ 6.0.5!

davidgilbertson · 2020-12-30T08:40:29Z

You work fast! 👏

vzaidman added the bug Something isn't working label Dec 23, 2020

vzaidman closed this as completed Dec 24, 2020

vzaidman reopened this Dec 30, 2020

vzaidman closed this as completed in c3be12c Dec 30, 2020

This was referenced Mar 15, 2021

Bump @welldone-software/why-did-you-render from 4.2.6 to 6.1.1 pprice/art.pprice.me#97

Closed

Bump @welldone-software/why-did-you-render from 4.3.2 to 6.1.1 in /election/web nimbella/demo-projects#129

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RangeError: Maximum call stack size exceeded #168

RangeError: Maximum call stack size exceeded #168

odeal4ik commented Dec 23, 2020 •

edited

Loading

odeal4ik commented Dec 23, 2020

vzaidman commented Dec 23, 2020

vzaidman commented Dec 23, 2020 •

edited

Loading

vzaidman commented Dec 23, 2020

odeal4ik commented Dec 23, 2020

odeal4ik commented Dec 23, 2020 •

edited

Loading

vzaidman commented Dec 24, 2020

vzaidman commented Dec 24, 2020 •

edited

Loading

odeal4ik commented Dec 24, 2020 •

edited

Loading

vzaidman commented Dec 24, 2020 •

edited

Loading

odeal4ik commented Dec 24, 2020

vzaidman commented Dec 24, 2020

odeal4ik commented Dec 24, 2020

vzaidman commented Dec 24, 2020

odeal4ik commented Dec 24, 2020 •

edited

Loading

vzaidman commented Dec 24, 2020

odeal4ik commented Dec 24, 2020

odeal4ik commented Dec 24, 2020

vzaidman commented Dec 24, 2020

odeal4ik commented Dec 24, 2020

davidgilbertson commented Dec 30, 2020

vzaidman commented Dec 30, 2020

vzaidman commented Dec 30, 2020 •

edited

Loading

davidgilbertson commented Dec 30, 2020

RangeError: Maximum call stack size exceeded #168

RangeError: Maximum call stack size exceeded #168

Comments

odeal4ik commented Dec 23, 2020 • edited Loading

odeal4ik commented Dec 23, 2020

vzaidman commented Dec 23, 2020

vzaidman commented Dec 23, 2020 • edited Loading

vzaidman commented Dec 23, 2020

odeal4ik commented Dec 23, 2020

odeal4ik commented Dec 23, 2020 • edited Loading

vzaidman commented Dec 24, 2020

vzaidman commented Dec 24, 2020 • edited Loading

odeal4ik commented Dec 24, 2020 • edited Loading

vzaidman commented Dec 24, 2020 • edited Loading

odeal4ik commented Dec 24, 2020

vzaidman commented Dec 24, 2020

odeal4ik commented Dec 24, 2020

vzaidman commented Dec 24, 2020

odeal4ik commented Dec 24, 2020 • edited Loading

vzaidman commented Dec 24, 2020

odeal4ik commented Dec 24, 2020

odeal4ik commented Dec 24, 2020

vzaidman commented Dec 24, 2020

odeal4ik commented Dec 24, 2020

davidgilbertson commented Dec 30, 2020

vzaidman commented Dec 30, 2020

vzaidman commented Dec 30, 2020 • edited Loading

davidgilbertson commented Dec 30, 2020

odeal4ik commented Dec 23, 2020 •

edited

Loading

vzaidman commented Dec 23, 2020 •

edited

Loading

odeal4ik commented Dec 23, 2020 •

edited

Loading

vzaidman commented Dec 24, 2020 •

edited

Loading

odeal4ik commented Dec 24, 2020 •

edited

Loading

vzaidman commented Dec 24, 2020 •

edited

Loading

odeal4ik commented Dec 24, 2020 •

edited

Loading

vzaidman commented Dec 30, 2020 •

edited

Loading