-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn on non-plain objects with same prototype and own fields #74
Labels
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
Comments
Can I pick this up? |
yes, go on :) |
@VariableVasasMT no success? :) |
@vzaidman I am extremely sorry, shit hit the fan, will pick this up, this week. |
what's up @VariableVasasMT? |
@vzaidman @VariableVasasMT I saw this issue was stale for few months so I opened a PR for it, hope you don't mind. |
Great! |
This was referenced Mar 15, 2021
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
Right now there is a false negative with non-plain objects passed as props, e.g. errors:
here,
error
prop is deep equal to the previous value but there's no warningOne possible solution is to check both
Object.getPrototypeOf(obj)
andObject.keys(obj)
for non-plain objectsThe text was updated successfully, but these errors were encountered: