Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not upload all data every time #10

Closed
hesyifei opened this issue Jun 19, 2020 · 1 comment
Closed

Do not upload all data every time #10

hesyifei opened this issue Jun 19, 2020 · 1 comment
Assignees
@hesyifei
Labels
enhancement New feature or request

Comments

@hesyifei
Copy link
Member

hesyifei commented Jun 19, 2020 •
edited

This is making the UI slow when there are e.g. 150 pings stored already.

Maybe upload by week (check MD5 of previous week to ensure the data is complete)?

Or only uploadDataAsync() when complete, and not during each onNextSelect().

This is also necessary because there is a 16MB database set limit for the Firebase SDK (https://firebase.google.com/docs/database/usage/limits#writes) - see also #23.
@hesyifei hesyifei added the enhancement New feature or request label Jun 19, 2020
@hesyifei hesyifei self-assigned this Jun 19, 2020
@hesyifei hesyifei mentioned this issue Jun 20, 2020
Merged
@hesyifei hesyifei mentioned this issue Aug 4, 2020
Closed
@hesyifei hesyifei mentioned this issue Aug 17, 2020
Merged
@hesyifei
Copy link
Member Author

hesyifei commented Jul 5, 2021 •
edited

Resolved by #75 and #76.

@hesyifei hesyifei closed this as completed Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hesyifei hesyifei

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hesyifei