Windows node-jq and jq fix #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wellsjo
reviewed
Dec 29, 2016
| @@ -70,6 +70,8 @@ class Editor extends EventEmitter { | |||
|
|
|||
| // Path to store data file so it can be read for jq (required for large input) | |||
| this.tmp = path.resolve(__dirname, '..', 'tmp', 'data.json') | |||
| @@ -249,7 +251,7 @@ class Editor extends EventEmitter { | |||
| fs.writeFileSync(this.tmp, JSON.stringify(this.data)) | |||
There was a problem hiding this comment.
We could prob use the same tmpRelative path here. Let's change tmpRelative back to to tmp though if we delete the other one.
|
LGTM 👍 |
|
@MaanooAk this ended up causing it not to work on Mac. we need to find a better solution, or at least something that separates the tmp path for both operating systems. |
|
I have no experience with mac, I am sorry I can't help (or test)... but using the old way for mac and the new way for everything else should be easy to implement. Can you test on mac? |
|
@MaanooAk Yeah I will try that today. Been really busy lately so I didn't even notice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-jqv.0.5.0 now supports windowsjqhas a limit to the length of the arguments, I changed the path of the tmp file from absolute to relative (= smaller) and it works.This pr resolves all jq issues in Windows (#56 and others?)