Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onFinish is only called after first finishing an animation #469

Closed
DamianPereira opened this issue Jun 7, 2021 · 3 comments · Fixed by #475
Closed

onFinish is only called after first finishing an animation #469

DamianPereira opened this issue Jun 7, 2021 · 3 comments · Fixed by #475
Labels
bug Something isn't working

Comments

@DamianPereira
Copy link

Bug Report

Describe the Bug

I'm trying to use the onFinish callback, together with controlling play status. After the animation finishes for the first time, the onFinish callback will be called, but not on subsequent calls.

How to Reproduce

Add an onFinish handler, start the animation with getAnimation().play() twice.

CodeSandbox Link

Bug example.

Expected Behavior

onFinish should be called whenever playState switches from 'running' to 'finished'

Your Environment

  • Device: Lenovo thinkpad
  • OS: Manjaro Linux
  • Browser: Both Chrome and Firefox tested.
  • Version: Both 0.9, and 0.7.4 show this behavior. I have not tested 0.8, should
@wellyshen
Copy link
Owner

wellyshen commented Jun 8, 2021

@DamianPereira Thank you for reporting this issue, will fix it soon.

@wellyshen wellyshen added the bug Something isn't working label Jun 8, 2021
@wellyshen wellyshen linked a pull request Jun 8, 2021 that will close this issue
@wellyshen
Copy link
Owner

wellyshen commented Jun 8, 2021

@DamianPereira It should be fixed in v0.9.1.

@DamianPereira
Copy link
Author

Thanks a lot for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants