Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependecy of typing_extensions to ^4.0.0 #250

Closed
thibautd opened this issue Dec 13, 2021 · 5 comments
Closed

Upgrade dependecy of typing_extensions to ^4.0.0 #250

thibautd opened this issue Dec 13, 2021 · 5 comments

Comments

@thibautd
Copy link
Contributor

thibautd commented Dec 13, 2021

Hello,

I would like to know if it's possible to upgrade the dependency to typing_extensions >= 4.0.0.

As of now we cannot introduce some external dependencies like pydantic in our project because of dependency conflicts with django-test-migrations. I don't exactly know if some breaking changes have been introduce in v4, however on the project README we can read the following:

Starting with version 4.0.0, typing_extensions uses Semantic Versioning. The major version is incremented for all backwards-incompatible changes, including dropping support for older Python versions. Therefore, it's safe to depend on typing_extensions like this: typing_extensions >=x.y, <(x+1), where x.y is the first version that includes all features you need.

@sobolevn
Copy link
Member

Please, make a PR! 👍

@thibautd
Copy link
Contributor Author

It doesn't look that simple :-(

thibaut@thibaut ~/D/django-test-migrations (master) [1]> poetry update
Updating dependencies
Resolving dependencies... (0.0s)

  SolverProblemError

  Because no versions of wemake-python-styleguide match >0.15,<0.15.1 || >0.15.1,<0.15.2 || >0.15.2,<0.15.3 || >0.15.3,<0.16
   and wemake-python-styleguide (0.15.0) depends on typing_extensions (>=3.6,<4.0), wemake-python-styleguide (>=0.15,<0.15.1 || >0.15.1,<0.15.2 || >0.15.2,<0.15.3 || >0.15.3,<0.16) requires typing_extensions (>=3.6,<4.0).
  And because wemake-python-styleguide (0.15.1) depends on typing_extensions (>=3.6,<4.0), wemake-python-styleguide (>=0.15,<0.15.2 || >0.15.2,<0.15.3 || >0.15.3,<0.16) requires typing_extensions (>=3.6,<4.0).
  And because wemake-python-styleguide (0.15.2) depends on typing_extensions (>=3.6,<4.0)
   and wemake-python-styleguide (0.15.3) depends on typing_extensions (>=3.6,<4.0), wemake-python-styleguide (>=0.15,<0.16) requires typing_extensions (>=3.6,<4.0).
  So, because django-test-migrations depends on both typing_extensions (^4.0) and wemake-python-styleguide (^0.15), version solving failed.

  at ~/Library/Application Support/pypoetry/venv/lib/python3.10/site-packages/poetry/puzzle/solver.py:241 in _solve
      237│             packages = result.packages
      238│         except OverrideNeeded as e:
      239│             return self.solve_in_compatibility_mode(e.overrides, use_latest=use_latest)
      240│         except SolveFailure as e:
    → 241│             raise SolverProblemError(e)
      242│
      243│         results = dict(
      244│             depth_first_search(
      245│                 PackageNode(self._package, packages), aggregate_package_nodes

@sobolevn
Copy link
Member

Ok, I need to release a new version of WPS 😢

@sobolevn
Copy link
Member

sobolevn commented Dec 13, 2021

Now https://github.com/wemake-services/wemake-python-styleguide/releases/tag/0.16.0 with new typing_extensions support is released. Please, report back if anything else is broken! 👍

@sobolevn
Copy link
Member

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants