New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to new eradicate api #157
Update to new eradicate api #157
Conversation
Related #161 |
So I updated the dependency to eradicate v2. The failed CI is because of safety complaining about pip<19.2 used in the py35 test. |
Let's drop py35 then. |
Should I do this in this PR or do u want to do this in another PR? |
Yes, this PR is fine 👍 |
Py3.5 is dropped. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! 👍
So finally got the time to fix the CI issue. Hope now its OK? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! Great work!
Thanks a lot! 👍 |
@sobolevn I'm looking forward to it being released it :) |
Will do soon 🙂 |
Even so the API of eradicate does change the new implementation is not that different.
--eradicate-whitelist
and--eradicate-whitelist-extend
which correspond to the appropriate flags from eradicate._Options
class because I could not find a reason to keep it. Instead it is now a dict.in_place
option which was present in the_Options
class because this setting only effectsEradicate.fix_file()
which is the 'parent' function to the here usedEradicate.filter_commented_out_code()
and does not get called.test_incorrect_fixture()
which should have failed on current master but does not. I dunno why.EDIT: when
eradicate
2.0.0
is released I will update the dependency and finish this PR. Then the CI should also succeed. I tested all thing the CI does locally with success.