Forbid getattr(x, 'foobar')

[vergeev]

As per the docs:

getattr(x, 'foobar') is equivalent to x.foobar

This may lead a reader to believe that getattr(obj, 'attribute') will not throw an exception.

Correct

x.foobar
getattr(x, 'foobar', None)
getattr(x, some_variable, None)

Incorrect

getattr(x, 'foobar')

[sobolevn]

But what if we have the following function:

def fetch_property(obj, key_name):
     return getattr(obj, key_name)

And I want to throw an exception here! Because I prefer an exception over None.
You solution implies that we will have to manually raise these exceptions:

foobar = getattr(x, 'foobar', None)
if foobar is None:
    raise AttributeError()

[vergeev]

Good catch! What I actually meant is prohibit the case in which the second argument is a string literal (which is always something constant).

I've updated the issue.

[sobolevn]

Anyway, this does not remove my consideration about consciously rising an exception here.
I use both versions with 50/50 rate.

@vergeev I guess that you are talking about beginners, who make this error and crush their programs. But, that's not the case here.

Thanks for your suggestion, but I am going to reject it.
Please, open new ones if you have any. I appreciate your attitude towards this project.

Cheers. 👍