Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using in instead of multiple == #602

Closed
sobolevn opened this issue Jun 21, 2019 · 3 comments
Closed

Consider using in instead of multiple == #602

sobolevn opened this issue Jun 21, 2019 · 3 comments
Assignees
@sobolevn
Labels
help wanted Extra attention is needed level:starter Good for newcomers rule request Adding a new rule
Milestone
Version 0.10.0

Comments

@sobolevn
Copy link
Member

Rule request

Thesis

When we have more than two == operators it is time to use in operator.
https://github.com/PyCQA/pylint/blob/5a86fddcb815ebd08fbc3ffcbaf7b11c2ba2e107/pylint/checkers/refactoring.py#L157

Reasoning

It makes your code more readable and allows to increase the in container even more without much pain.

Original: #431
@sobolevn sobolevn added help wanted Extra attention is needed level:starter Good for newcomers rule request Adding a new rule labels Jun 21, 2019
@hemanthsavasere
Copy link

Hi @sobolevn,
I would love work on this issue.

Thanks and Regards,
Hemanth Savasere

@sobolevn
Copy link
Member Author

Awesome! @hemanthsavasere please, feel free to ask any questions or to send WIP pull requests to check the direction. 👍

@sobolevn sobolevn added this to the Version 0.10.0 milestone Jun 25, 2019
@sobolevn
Copy link
Member Author

@hemanthsavasere how's your progress? I can take this over.
I am planning a release pretty soon. And I want to have all compare related stuff in there.

@sobolevn sobolevn self-assigned this Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
help wanted Extra attention is needed level:starter Good for newcomers rule request Adding a new rule
Projects
None yet
Milestone
Version 0.10.0
Development

No branches or pull requests
2 participants
@sobolevn @hemanthsavasere