Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force people to use a > b > c instead of a > b and b > c #646

Closed
sobolevn opened this issue Jul 11, 2019 · 3 comments
Closed

Force people to use a > b > c instead of a > b and b > c #646

sobolevn opened this issue Jul 11, 2019 · 3 comments
Assignees
@sobolevn
Labels
help wanted Extra attention is needed level:starter Good for newcomers rule request Adding a new rule
Milestone
Version 0.10.0

Comments

@sobolevn
Copy link
Member

Rule request

Thesis

This should only work for >, <, >=, <=, !=, and == signs.

Reasoning

This should bring consistency to the compare statements.
@sobolevn sobolevn added help wanted Extra attention is needed level:starter Good for newcomers rule request Adding a new rule labels Jul 11, 2019
@sobolevn sobolevn added this to the Version 0.10.0 milestone Jul 11, 2019
@sobolevn sobolevn self-assigned this Jul 11, 2019
@sobolevn
Copy link
Member Author

Correct:
a > c and c > b +
a > c and c >= b +
a >= c and c > b +
a > c and c >= b +

Wrong:
a >= c and c <= b - (will be a >= c <= b and it is forbidden)
a < c and c != b -

The basic rule is: we should check that the resulting compare is homogenous.

@sobolevn
Copy link
Member Author

sobolevn commented Jul 11, 2019 •
edited

a == c and c == b +
a == c and c == b and c == d +

@sobolevn
Copy link
Member Author

a > c and a > b -
a > c and a < b -> b > a > c

Related: https://github.com/PyCQA/pylint/blob/5a86fddcb815ebd08fbc3ffcbaf7b11c2ba2e107/pylint/checkers/refactoring.py#L743

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
help wanted Extra attention is needed level:starter Good for newcomers rule request Adding a new rule
Projects
None yet
Milestone
Version 0.10.0
Development

No branches or pull requests
1 participant
@sobolevn