Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the order of methods inside a class #654

Closed
sobolevn opened this issue Jul 12, 2019 · 0 comments
Closed

Ensure the order of methods inside a class #654

sobolevn opened this issue Jul 12, 2019 · 0 comments
Labels
help wanted Extra attention is needed level:advanced Needs a lot of care rule request Adding a new rule

Comments

@sobolevn
Copy link
Member

Rule request

Thesis

We need to make sure that all classes have ordered methods:

  1. __init__ and __new__
  2. all public and magic methods
  3. all protected methods
  4. all private method (if some)

We should not care about anything else.

See #139

Reasoning

This is done for readability and consistency.

@sobolevn sobolevn added help wanted Extra attention is needed rule request Adding a new rule level:advanced Needs a lot of care labels Jul 12, 2019
@sobolevn sobolevn added this to the Version 0.12.0 milestone Jul 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed level:advanced Needs a lot of care rule request Adding a new rule
Projects
None yet
Development

No branches or pull requests

1 participant