Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jodit 3.6: Word/HTML insert dialog does not open #24

Closed
Scaenicus opened this issue Apr 13, 2021 · 8 comments
Closed

Jodit 3.6: Word/HTML insert dialog does not open #24

Scaenicus opened this issue Apr 13, 2021 · 8 comments

Comments

@Scaenicus
Copy link

Version Jodit 3.6.8

There are new dialogues in Jodit which try to render fullscreen modals.

Those seem to be prevented by jodit-vue.

image

image

Temporary solution

Prevent Jodit from asking and define paste-defaults.

            let joditConfig = {
                "askBeforePasteFromWord": false,
                "askBeforePasteHTML": false,
                "defaultActionOnPaste": "insert_as_html",
                "defaultActionOnPasteFromWord": "insert_as_html",
                "processPasteFromWord": true,
                "processPasteHTML": true,

Thank you for your work with jodit-vue!

@Scaenicus
Copy link
Author

Different default values:

https://xdsoft.net/jodit/doc/types/InsertMode/

@WendellAdriel
Copy link
Owner

@Scaenicus thanks for reporting that, I'm going to take a look as soon as I have some time.
Sorry for the delay, but I had some health issues recently and I'm not having much time and energy to check here, I'll do that ASAP

@Scaenicus
Copy link
Author

@WendellAdriel No worries, the workaround works just fine for now.
Most of the time insert_clear_html is needed, most users needing other functions are able to insert plaintext on their own, or even use the code editor.

Take care of your health!

@WendellAdriel
Copy link
Owner

Thank you so much, @Scaenicus.
Also, I released yesterday a new version of the wrapper, can you check if the issue persists?

@Scaenicus
Copy link
Author

Scaenicus commented Apr 21, 2021

Certainly.

Testing with "jodit-vue": "^2.4.0" (Lock file version 2.4.0)

Summary: Seems to work perfectly. Thank you!

Changes to config-object

                "askBeforePasteFromWord": true,     // <----
                "askBeforePasteHTML": true,         // <----
                "defaultActionOnPaste": "insert_clear_html",
                "defaultActionOnPasteFromWord": "insert_clear_html",
                "processPasteFromWord": true,
                "processPasteHTML": true,

Test

Test is on a purposefully over-encumbered development page, which usually reveals strange interactions and racing conditions.

HTML text with images right from a random page

  • Modal shows
  • All button variants work
    • HTML looks horrible but that's an issue with the random source... technically it works.

Formatted text from Libre Office's Writer

  • Was interpreted by jodit as HTML, otherwise works perfectly.

Formatted text from MS Office's Word

  • I have reports that it works now.
  • Later this day I will retest on the machine with an Microsoft Office license on my own.
  • Edit: Tested myself too, works fine!

@Scaenicus
Copy link
Author

fix: Jodit version 3.6.8 insert-modals are now shown again for HTML and MS Word.

@WendellAdriel
Copy link
Owner

That's amazing @Scaenicus, thank you so much for your help here!!! I really appreciate it!

@Scaenicus
Copy link
Author

You are welcome. Thank you for maintaining this great wrapper!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants