Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docs on compute_embedding.py needed for inference #14

Closed
linminhtoo opened this issue Jul 28, 2022 · 2 comments
Closed

add docs on compute_embedding.py needed for inference #14

linminhtoo opened this issue Jul 28, 2022 · 2 comments

Comments

@linminhtoo
Copy link

linminhtoo commented Jul 28, 2022

hello (again),

sorry that I am raising multiple issues. just want to make it easier for everyone else to start using this awesome work.

i didn't a note about how one could compute molecular fingerprints / GNN embeddings for a dataset. only after some CTRL+F, i found that scripts/compute_embedding.py does it.
https://github.com/wenhao-gao/SynNet/blob/master/scripts/compute_embedding.py

so, it would be a good idea to add this to the README. I believe we need to do this step before running any inference.

@linminhtoo linminhtoo changed the title add information about compute_embedding.py add docs on compute_embedding.py needed for inference Jul 28, 2022
@chrulm
Copy link
Collaborator

chrulm commented Sep 15, 2022

Hey,

Thanks for the comments!

We've addressed this issue in a fork and will merge it once its not a WIP anymore. In the meantime, feel free to check out https://github.com/chrulm/SynNet/blob/refactor-syntree-generation/INSTRUCTIONS.md and let us know what you think!

@chrulm chrulm closed this as completed Sep 15, 2022
@linminhtoo
Copy link
Author

Great! I will have a look when I have some time, probably this or next weekend. Good to see you're working on refactoring synnet which will definitely make it more accessible to researchers and practitioners alike. Just curious, are you under the Coley group?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants