Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.8.0 release tag isn't on the default branch #25

Closed
phillco opened this issue Oct 3, 2022 · 4 comments
Closed

1.8.0 release tag isn't on the default branch #25

phillco opened this issue Oct 3, 2022 · 4 comments

Comments

@phillco
Copy link
Contributor

phillco commented Oct 3, 2022

Right now, pre-commit autoupdate thinks 1.7.4 is the latest version and will actually downgrade installations of 1.8.0: talonhub/community#991

I looked up how pre-commit determines the latest version, and it says this:

By default, this will bring the hooks to the latest tag on the default branch.

I think the problem is that the 1.8.0 tag isn't on the default branch (dev), so that's why it's not considered as the latest release. 1.7.4 is.

Screen Shot 2022-10-03 at 2 41 44 PM

Force pushing 1.8.0 to a commit on dev, or creating a new 1.8.1 tag that is, should resolve the problem.

You can reproduce by cd'ing into knausj and running pre-commit autoupdate.

@wenkokke
Copy link
Owner

wenkokke commented Oct 4, 2022

Wild, thanks!

@phillco
Copy link
Contributor Author

phillco commented Oct 12, 2022

Mind taking a stab at pushing a new tag? pre-commit.ci is still trying to downgrade 1.8.0 installations: phillco/talon-axkit#40. I would open a pull request, except you can't open a pull request for a tag :)

@wenkokke
Copy link
Owner

Hopefully fixed now?

@phillco
Copy link
Contributor Author

phillco commented Oct 14, 2022

Yup! Thanks!

$ pre-commit autoupdate
Updating https://github.com/pre-commit/pre-commit-hooks ... already up to date.
Updating https://github.com/pre-commit/mirrors-prettier ... [INFO] Initializing environment for https://github.com/pre-commit/mirrors-prettier.
updating v3.0.0-alpha.0 -> v3.0.0-alpha.2.
Updating https://github.com/ikamensh/flynt/ ... already up to date.
Updating https://github.com/pycqa/isort ... already up to date.
Updating https://github.com/psf/black ... [INFO] Initializing environment for https://github.com/psf/black.
updating 22.8.0 -> 22.10.0.
Updating https://github.com/Lucas-C/pre-commit-hooks ... already up to date.
Updating https://github.com/wenkokke/talonfmt ... [INFO] Initializing environment for https://github.com/wenkokke/talonfmt.
updating 1.8.0 -> 1.8.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants