Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage without any framework #4364

Closed
gurumark opened this issue May 22, 2019 · 10 comments · Fixed by #4403
Closed

Usage without any framework #4364

gurumark opened this issue May 22, 2019 · 10 comments · Fixed by #4403
Labels
css Issues stemming from our compiled CSS or source CSS files. feature Issues asking for a new feature to be added, or an existing one to be extended or modified. has PR Issues that has been fixed with a PR.

Comments

@gurumark
Copy link

Is there anyway to use library without including bootstrap js or css? These files are very heavy and I am not sure what percentage of the code included in these files are really used by bootstrap tables?
Thanks in advance.

@wenzhixin
Copy link
Owner

Here is the list of the integration with some of the most widely used CSS frameworks: https://bootstrap-table.com/themes/. You can use another CSS framework instead of bootstrap.

@wenzhixin wenzhixin added the css Issues stemming from our compiled CSS or source CSS files. label May 22, 2019
@gurumark
Copy link
Author

gurumark commented May 22, 2019

How about no framework?
I see:
link rel="stylesheet" href="https://stackpath.bootstrapcdn.com/bootstrap/4.2.1/css/bootstrap.min.css"
script src="https://stackpath.bootstrapcdn.com/bootstrap/4.2.1/js/bootstrap.min.js"

in this page.
https://bootstrap-table.com/docs/getting-started/introduction/
Will it work if I don't include these 2 files?

@UtechtDustin
Copy link
Collaborator

I also thin we should add a version without a requirement of a whole css framework.
What do you think about a basic css implementation for the bootstrap table ?
@wenzhixin @djhvscf

@wenzhixin wenzhixin added the feature Issues asking for a new feature to be added, or an existing one to be extended or modified. label Jun 1, 2019
@UtechtDustin
Copy link
Collaborator

We could use the generator from icomoon.io with the icon pack Feather (its MIT).
I will generate the css and the svgs for us, also it will generate a json with the select icons so we could reimport it to icomoon if we would add new icons.
What do you think @wenzhixin @djhvscf ?

@wenzhixin
Copy link
Owner

It’s great @UtechtDustin.

@djhvscf
Copy link
Collaborator

djhvscf commented Jun 5, 2019

@UtechtDustin it is a very very good idea!! 🥇

@gurumark
Copy link
Author

gurumark commented Jun 5, 2019

@UtechtDustin Thanks much!!

@gurumark gurumark changed the title Usage without bootstrap Usage without any framework Jun 5, 2019
@UtechtDustin UtechtDustin added the has PR Issues that has been fixed with a PR. label Jun 10, 2019
@pipiscrew
Copy link

@pattishih
Copy link

pattishih commented Oct 18, 2019

One comment on this—the current CSS selectors for Bootstrap Table are a bit too selective, making it difficult to override property values that I would like to customize to my page without using !important or using just as many selectors in my custom CSS. These characters in the file can add up and increase the time for a page to load (particularly for slower mobile data connections).

An example:

.bootstrap-table .fixed-table-container .table tbody tr.selected td {
  background-color: rgba(0, 0, 0, 0.075);
}

This can probably be reduced to .bootstrap-table .selected td

...of course, I can also edit the Bootstrap Table CSS file, which is what I've done, but the downside is that I had to find my own CDN to serve it (for speed).

@pipiscrew
Copy link

Bootstrap 5.0 alpha arrives, sans jQuery
https://www.infoworld.com/article/3563416/bootstrap-50-alpha-arrives-sans-jquery.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css Issues stemming from our compiled CSS or source CSS files. feature Issues asking for a new feature to be added, or an existing one to be extended or modified. has PR Issues that has been fixed with a PR.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants