Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White space between header and row, using filter control and table-height #5541

Closed
DataSupplier opened this issue Jan 14, 2021 · 8 comments · Fixed by #5583
Closed

White space between header and row, using filter control and table-height #5541

DataSupplier opened this issue Jan 14, 2021 · 8 comments · Fixed by #5583
Assignees
Labels
Bug Issues which are marked as Bug confirmed Issues that have been confirmed with a reduced test case and identify a bug. has PR Issues that has been fixed with a PR.

Comments

@DataSupplier
Copy link

Bootstraptable version(s) affected:
Bootstrap 5 + Bootstrap-Table 1.81 and below.

Description
Visually table is not showing correctly, having a white space between the column header and the row.
The last row is not readable.

Using the same setup disabling the table-height option, the table works and shows fine.
Using the same setup disabling the filter-control extension, the table works and shows fine.

Example
https://live.bootstrap-table.com/code/DataSupplier/6195

@DataSupplier DataSupplier added the Bug Issues which are marked as Bug label Jan 14, 2021
@UtechtDustin UtechtDustin added the confirmed Issues that have been confirmed with a reduced test case and identify a bug. label Jan 19, 2021
@UtechtDustin
Copy link
Collaborator

For the developer which will fix this bug: the problem is the table-sm (Changes the heights).
Minimal example: https://live.bootstrap-table.com/code/UtechtDustin/6274

@fabiawrc
Copy link

confirm the same problem

@djhvscf
Copy link
Collaborator

djhvscf commented Mar 4, 2021

Working on it

@djhvscf
Copy link
Collaborator

djhvscf commented Apr 18, 2021

Fixed in #5583

@djhvscf djhvscf mentioned this issue Apr 18, 2021
36 tasks
@djhvscf djhvscf added the has PR Issues that has been fixed with a PR. label Apr 18, 2021
@djhvscf
Copy link
Collaborator

djhvscf commented Nov 20, 2021

Example with fix: https://live.bootstrap-table.com/code/djhvscf/9665

@UtechtDustin
Copy link
Collaborator

@djhvscf
If i use the example from @DataSupplier and your branch the fix won't work: https://live.bootstrap-table.com/code/UtechtDustin/9668

@wenzhixin
Copy link
Owner

I think the problem is data-filter-control="".

@UtechtDustin
Copy link
Collaborator

@wenzhixin i don't think so. If you change it to e.g. data-filter-control="select" there is still a space between the header and the table.
The footer also looks odd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues which are marked as Bug confirmed Issues that have been confirmed with a reduced test case and identify a bug. has PR Issues that has been fixed with a PR.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants