Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear Filter while using cookie ext. or search #5572

Closed
g3rd0 opened this issue Jan 30, 2021 · 6 comments · Fixed by #5583
Closed

Clear Filter while using cookie ext. or search #5572

g3rd0 opened this issue Jan 30, 2021 · 6 comments · Fixed by #5583
Assignees
@djhvscf
Labels
Bug Issues which are marked as Bug confirmed Issues that have been confirmed with a reduced test case and identify a bug. cookie Issues for the cookie extension. filter-control Issues for the filter-control extension. has PR Issues that has been fixed with a PR.

Comments

@g3rd0
Copy link
Contributor

g3rd0 commented Jan 30, 2021

Bootstraptable version(s) affected:
1.18.2

Description
When using different settings, the filter is no longer reset cleanly.

Variant a)
If the cookie extension is used, the value cannot be reset via the filter. This can then only be removed via Clear Filter.
https://live.bootstrap-table.com/code/sebastiangehrt/6447

Variant b)
If the search field is also used in addition to the cookie extension, the filter cannot be reset via Clear Filter.
https://live.bootstrap-table.com/code/sebastiangehrt/6448
@g3rd0 g3rd0 added the Bug Issues which are marked as Bug label Jan 30, 2021
@UtechtDustin UtechtDustin added confirmed Issues that have been confirmed with a reduced test case and identify a bug. cookie Issues for the cookie extension. filter-control Issues for the filter-control extension. labels Jan 30, 2021
@djhvscf
Copy link
Collaborator

djhvscf commented Feb 8, 2021 •
edited

Working on this. I have been working on create the filter control from scratch

@djhvscf
Copy link
Collaborator

djhvscf commented Mar 4, 2021

Thanks @wenzhixin.. Catching up everything

@djhvscf
Copy link
Collaborator

djhvscf commented Apr 18, 2021

@sebastiangehrt I'm not sure about this error. Can you give us the repro steps?

@djhvscf djhvscf added the awaiting reply Issues that are awaiting reply, will be closed if there is no any response in 7 days. label Apr 18, 2021
@g3rd0
Copy link
Contributor Author

g3rd0 commented Apr 20, 2021

Variant A:
Choose Price 1$, Click on Clear Button => Filter is reset
Choose Price 1$, Choose "blank" Entry => Filter is still on 1$

Variant B:
Choose Price 1$, Click on Clear Button => Filter is still on 1$
Choose Price 1$, Choose "blank" Entry => Filter is still on 1$

@djhvscf djhvscf removed the awaiting reply Issues that are awaiting reply, will be closed if there is no any response in 7 days. label Apr 20, 2021
@djhvscf
Copy link
Collaborator

djhvscf commented Apr 20, 2021

Fix: https://live.bootstrap-table.com/code/djhvscf/7445
Fix: https://live.bootstrap-table.com/code/djhvscf/7446

PR: #5583

@djhvscf djhvscf mentioned this issue Apr 20, 2021
Merged
36 tasks
@djhvscf djhvscf added the has PR Issues that has been fixed with a PR. label Apr 20, 2021
@djhvscf
Copy link
Collaborator

djhvscf commented Nov 23, 2021

Example with fix: https://live.bootstrap-table.com/code/djhvscf/7445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djhvscf djhvscf

Labels
Bug Issues which are marked as Bug confirmed Issues that have been confirmed with a reduced test case and identify a bug. cookie Issues for the cookie extension. filter-control Issues for the filter-control extension. has PR Issues that has been fixed with a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improving filter control wenzhixin/bootstrap-table
3 participants
@djhvscf @UtechtDustin @g3rd0