Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table filter control with cell content having links <a> is no longer working #5588

Closed
sdespont opened this issue Feb 17, 2021 · 25 comments · Fixed by #5583
Closed

Table filter control with cell content having links <a> is no longer working #5588

sdespont opened this issue Feb 17, 2021 · 25 comments · Fixed by #5583
Assignees
Labels
Bug Issues which are marked as Bug filter-control Issues for the filter-control extension. has PR Issues that has been fixed with a PR.

Comments

@sdespont
Copy link
Contributor

Bootstraptable version(s) affected:
1.8.2

Description
bootstrap-table-filter-control using data-filter-control="select" with cell content having links is no longer working
image

image

Example
https://jsfiddle.net/8aw4ox96/

Possible (optional)

Additional context

@sdespont sdespont added the Bug Issues which are marked as Bug label Feb 17, 2021
@wenzhixin wenzhixin added the filter-control Issues for the filter-control extension. label Feb 27, 2021
@wenzhixin
Copy link
Owner

Please provide an Online Example to show your problem, thanks!

@sdespont
Copy link
Contributor Author

sdespont commented Feb 27, 2021

@djhvscf @wenzhixin Sure : https://live.bootstrap-table.com/code/sdespont/6739

Open the filter selection to see the problem

@djhvscf
Copy link
Collaborator

djhvscf commented Mar 4, 2021

@sdespont got it. I'm working on filter control rewrite

@nl492k
Copy link

nl492k commented Apr 7, 2021

Experienced this issue today. Worked around issue with filterData and passing a list of options. I did do enough investigating to find that it was related to " and ' in the href attribute of the anchor tag.

@djhvscf
Copy link
Collaborator

djhvscf commented Apr 18, 2021

Fixed in #5583

@djhvscf djhvscf closed this as completed Apr 18, 2021
@djhvscf djhvscf reopened this Apr 18, 2021
@djhvscf djhvscf mentioned this issue Apr 18, 2021
36 tasks
@djhvscf djhvscf added the has PR Issues that has been fixed with a PR. label Apr 18, 2021
@sdespont
Copy link
Contributor Author

sdespont commented Jul 22, 2021

@djhvscf any chance to have a merge in next weeks with a new bootstrap-table release?

@UtechtDustin
Copy link
Collaborator

@wenzhixin ?

@djhvscf
Copy link
Collaborator

djhvscf commented Jul 26, 2021

This is still in progress.

@sdespont
Copy link
Contributor Author

@djhvscf any news/plans about when the fix will be released?

@djhvscf
Copy link
Collaborator

djhvscf commented Oct 11, 2021

@sdespont
Copy link
Contributor Author

Hi @djhvscf , version 1.9.0 has been released 3 days ago, can we expect a new version of the filter control plugin? A lot of bug have been fixed in #5583 (thanks for this!) and this one is a real problem for some people.

@UtechtDustin
Copy link
Collaborator

@sdespont As you can see in the latest post (#5583 (comment)) @djhvscf will create a few examples and tests and then we are (hopefully) ready to merge.

@sdespont
Copy link
Contributor Author

@UtechtDustin Oh right, thanks for the answer

@djhvscf
Copy link
Collaborator

djhvscf commented Nov 11, 2021

I'm working on improving the rendering process

@djhvscf
Copy link
Collaborator

djhvscf commented Nov 20, 2021

Example with the fix: https://live.bootstrap-table.com/code/djhvscf/9666

@UtechtDustin
Copy link
Collaborator

@djhvscf
The fix works, but i don't think it makes sense like that.
None dev users don't understand the html stuff, some kind of bad UX i guess. We should use/show only the visible text (maybe we could implement it with a filterFormatter or something like that, which is overwritable by the dev).

@djhvscf
Copy link
Collaborator

djhvscf commented Nov 21, 2021

But it is the raw text
image
What do you mean? @UtechtDustin

@sdespont
Copy link
Contributor Author

sdespont commented Nov 21, 2021

@djhvscf In fact, I also have full tag with https://live.bootstrap-table.com/code/djhvscf/9666 and Chrome :
image

Maybe it is not your latest version?

@UtechtDustin
Copy link
Collaborator

@djhvscf check the screenshot from @sdespont.
That is the issue i mean, i'm using Firefox 94.0

@djhvscf
Copy link
Collaborator

djhvscf commented Nov 22, 2021

I think the online example may have cache problems.. @wenzhixin

@sdespont
Copy link
Contributor Author

@djhvscf, it had to because it is working well now

image

Thanks for the fix!

@UtechtDustin
Copy link
Collaborator

Works well for me too!
Thanks @djhvscf

@i-m-d
Copy link

i-m-d commented Dec 5, 2021

When will this fix be available to download ?

@djhvscf
Copy link
Collaborator

djhvscf commented Dec 5, 2021

@i-m-d we're working on the last issue that that PR is going to cover.. After that we can release a new version.

@sdespont
Copy link
Contributor Author

@djhvscf This problem appears again since 1.21.0 (OK in 1.20.2).

Do you have any idea why ?

The filter is not working if the link is containing a html link. Here is a sample to reproduce the problem : https://live.bootstrap-table.com/code/sdespont/13443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues which are marked as Bug filter-control Issues for the filter-control extension. has PR Issues that has been fixed with a PR.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants