Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter control extension does not support multiple themes. #5968

Open
djhvscf opened this issue Nov 28, 2021 · 1 comment
Open

Filter control extension does not support multiple themes. #5968

djhvscf opened this issue Nov 28, 2021 · 1 comment
Assignees
@djhvscf
Labels
Bug Issues which are marked as Bug confirmed Issues that have been confirmed with a reduced test case and identify a bug. filter-control Issues for the filter-control extension.

Comments

@djhvscf
Copy link
Collaborator

djhvscf commented Nov 28, 2021

Bootstraptable version(s) affected

1.19.1

Description

The filter control extensions does not support multiple theme.

Example(s)

You can see that the input and select controls don't have any style.

https://live.bootstrap-table.com/code/djhvscf/9771

Possible Solutions

We need to "migrate" the html for those controls to the corresponding themes files.

Additional Context

No response
@djhvscf djhvscf added Bug Issues which are marked as Bug confirmed Issues that have been confirmed with a reduced test case and identify a bug. filter-control Issues for the filter-control extension. labels Nov 28, 2021
@djhvscf djhvscf self-assigned this Nov 28, 2021
This was referenced Nov 28, 2021
Merged
Open
@sdespont
Copy link
Contributor

When setting theme data-icon-size="sm", the form-control class is missing because only form-control-sm is defined.

Therefore, the bootstrap render is not applied

image

image

https://live.bootstrap-table.com/code/sdespont/11317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djhvscf djhvscf

Labels
Bug Issues which are marked as Bug confirmed Issues that have been confirmed with a reduced test case and identify a bug. filter-control Issues for the filter-control extension.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sdespont @djhvscf