Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not catch all exceptions #21

Open
antoineleclair opened this issue May 11, 2015 · 1 comment
Open

Should not catch all exceptions #21

antoineleclair opened this issue May 11, 2015 · 1 comment

Comments

@antoineleclair
Copy link

except:

In the event of some other errors, the exception is just swallowed. For example, a network error. You should list the exceptions that you want to catch.

And I think the code expects that an exception will be raised if the status code is 4xx/5xx, but, as far as I know, it's not the case.

@ellardli
Copy link
Contributor

Got it. I'll check out the types of exceptions that the block can throw and expand the handler to handle them properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants